Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feature-activation): implement get endpoint #634

Merged
merged 1 commit into from
Jun 14, 2023
Merged

feat(feature-activation): implement get endpoint #634

merged 1 commit into from
Jun 14, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented May 28, 2023 •
edited
Loading

Depends on #633

Acceptance Criteria

  • Implement GET /feature endpoint

Resolves #632

@glevco glevco requested a review from jansegre as a code owner May 28, 2023 18:59
@glevco glevco self-assigned this May 28, 2023
@glevco glevco requested a review from msbrogli as a code owner May 28, 2023 18:59
@codecov
Copy link

codecov bot commented May 28, 2023 •
edited
Loading

Codecov Report

Merging #634 (659da6d) into master (ea7b859) will increase coverage by 0.07%.
The diff coverage is 92.80%.

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   83.78%   83.85%   +0.07%     
==========================================
  Files         246      247       +1     
  Lines       20309    20383      +74     
  Branches     2753     2756       +3     
==========================================
+ Hits        17016    17093      +77     
+ Misses       2711     2710       -1     
+ Partials      582      580       -2
Impacted Files Coverage Δ
hathor/manager.py 73.89% <72.22%> (-0.31%) ⬇️
hathor/builder/builder.py 92.97% <100.00%> (+0.10%) ⬆️
hathor/builder/resources_builder.py 94.39% <100.00%> (+0.16%) ⬆️
hathor/feature_activation/feature_service.py 96.87% <100.00%> (+0.04%) ⬆️
hathor/feature_activation/model/criteria.py 100.00% <100.00%> (ø)
hathor/feature_activation/resources/feature.py 100.00% <100.00%> (ø)
hathor/transaction/block.py 92.09% <100.00%> (+0.03%) ⬆️
hathor/transaction/storage/cache_storage.py 94.32% <100.00%> (+0.25%) ⬆️
hathor/transaction/storage/transaction_storage.py 91.04% <100.00%> (+0.04%) ⬆️
hathor/transaction/storage/tx_allow_scope.py 93.10% <100.00%> (ø)

... and 4 files with indirect coverage changes

@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from 09725e2 to 5cf821f Compare May 30, 2023 20:20
@glevco glevco force-pushed the feat/feature-activation/get-endpoint branch 4 times, most recently from fddc093 to a92e925 Compare May 30, 2023 21:13
msbrogli
msbrogli requested changes May 31, 2023
View reviewed changes
hathor/builder/resources_builder.py Outdated Show resolved Hide resolved
tests/resources/feature/test_feature.py Outdated Show resolved Hide resolved
hathor/feature_activation/resources/feature.py Outdated Show resolved Hide resolved
hathor/feature_activation/resources/feature.py Outdated Show resolved Hide resolved
hathor/feature_activation/resources/feature.py Outdated Show resolved Hide resolved
hathor/feature_activation/resources/feature.py Outdated Show resolved Hide resolved
hathor/feature_activation/resources/feature.py Outdated Show resolved Hide resolved
hathor/feature_activation/resources/feature.py Show resolved Hide resolved
hathor/feature_activation/resources/feature.py Outdated Show resolved Hide resolved
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch 2 times, most recently from df3c551 to f61e868 Compare May 31, 2023 13:46
@glevco glevco force-pushed the feat/feature-activation/get-endpoint branch from a92e925 to c250dc5 Compare May 31, 2023 13:51
@glevco glevco requested a review from msbrogli May 31, 2023 15:49
@glevco glevco marked this pull request as draft June 1, 2023 05:07
@glevco glevco mentioned this pull request Jun 1, 2023
Merged
msbrogli
msbrogli previously approved these changes Jun 1, 2023
View reviewed changes
hathor/feature_activation/model/criteria.py Show resolved Hide resolved
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from f61e868 to a0db26c Compare June 2, 2023 03:20
@glevco glevco force-pushed the feat/feature-activation/get-endpoint branch 2 times, most recently from 7c0d2f5 to ecd3d89 Compare June 5, 2023 20:39
jansegre
jansegre previously approved these changes Jun 6, 2023
View reviewed changes
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from 8a97f48 to 3008ef3 Compare June 7, 2023 15:55
@glevco glevco force-pushed the feat/feature-activation/get-endpoint branch from ecd3d89 to f40f182 Compare June 7, 2023 15:58
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from 3008ef3 to 2de80c1 Compare June 9, 2023 20:21
@glevco glevco force-pushed the feat/feature-activation/get-endpoint branch from f40f182 to 35836ff Compare June 9, 2023 20:28
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch 2 times, most recently from a71cd1b to 0bc0df8 Compare June 13, 2023 22:30
Base automatically changed from feat/feature-activation/bit-count-optimization to master June 14, 2023 01:01
@glevco glevco dismissed stale reviews from jansegre and msbrogli June 14, 2023 01:01

The base branch was changed.

@glevco glevco force-pushed the feat/feature-activation/get-endpoint branch from c19de4b to 2ad1126 Compare June 14, 2023 01:08
@glevco glevco marked this pull request as ready for review June 14, 2023 01:10
@glevco glevco force-pushed the feat/feature-activation/get-endpoint branch from 2ad1126 to f3f3d19 Compare June 14, 2023 14:04
@glevco glevco force-pushed the feat/feature-activation/get-endpoint branch from f3f3d19 to 659da6d Compare June 14, 2023 14:49
@glevco glevco merged commit d6aafe5 into master Jun 14, 2023
@glevco glevco deleted the feat/feature-activation/get-endpoint branch June 14, 2023 17:31
@jansegre jansegre mentioned this pull request Jul 12, 2023
Merged
2 tasks
This was referenced Aug 2, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansegre jansegre jansegre approved these changes

@msbrogli msbrogli msbrogli approved these changes

Assignees

@glevco glevco

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Activation] Implement GET endpoint
3 participants
@glevco @msbrogli @jansegre