Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(builder): Build IndexesManager on builders #640

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented May 30, 2023

Acceptance criteria

  1. Build IndexesManager on builders.
  2. Remove default value for Metrics.tx_storage.

@msbrogli msbrogli self-assigned this May 30, 2023
@msbrogli msbrogli requested a review from jansegre as a code owner May 30, 2023 22:46
@msbrogli msbrogli force-pushed the refactor/builder-indexes branch 7 times, most recently from 23cc018 to af91a6e Compare June 6, 2023 05:44
@msbrogli msbrogli force-pushed the refactor/builder-indexes branch from af91a6e to 229dac2 Compare June 7, 2023 07:43
@msbrogli msbrogli requested a review from glevco June 7, 2023 07:44
@msbrogli msbrogli force-pushed the refactor/builder-indexes branch from 229dac2 to 91a476e Compare June 7, 2023 07:47
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #640 (91a476e) into master (0dcf3b5) will decrease coverage by 0.11%.
The diff coverage is 96.72%.

❗ Current head 91a476e differs from pull request most recent head 512ac62. Consider uploading reports for the commit 512ac62 to get more accurate results

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
- Coverage   84.07%   83.96%   -0.11%     
==========================================
  Files         245      245              
  Lines       20282    20295      +13     
  Branches     2759     2762       +3     
==========================================
- Hits        17052    17041      -11     
- Misses       2635     2657      +22     
- Partials      595      597       +2     
Impacted Files Coverage Δ
hathor/builder/builder.py 91.86% <94.59%> (+0.95%) ⬆️
hathor/builder/cli_builder.py 72.53% <100.00%> (-0.14%) ⬇️
hathor/indexes/manager.py 91.30% <100.00%> (-0.87%) ⬇️
hathor/metrics.py 86.30% <100.00%> (-0.09%) ⬇️
hathor/transaction/storage/cache_storage.py 94.07% <100.00%> (-0.09%) ⬇️
hathor/transaction/storage/memory_storage.py 91.17% <100.00%> (+0.13%) ⬆️
hathor/transaction/storage/rocksdb_storage.py 94.57% <100.00%> (-0.21%) ⬇️
hathor/transaction/storage/transaction_storage.py 90.85% <100.00%> (-0.33%) ⬇️

... and 15 files with indirect coverage changes

glevco
glevco previously approved these changes Jun 9, 2023
hathor/builder/builder.py Outdated Show resolved Hide resolved
hathor/builder/cli_builder.py Outdated Show resolved Hide resolved
jansegre
jansegre previously approved these changes Jun 13, 2023
@msbrogli msbrogli dismissed stale reviews from jansegre and glevco via 512ac62 June 13, 2023 18:49
@msbrogli msbrogli force-pushed the refactor/builder-indexes branch from 91a476e to 512ac62 Compare June 13, 2023 18:49
@msbrogli msbrogli merged commit 512ac62 into master Jun 13, 2023
@msbrogli msbrogli deleted the refactor/builder-indexes branch June 13, 2023 18:54
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants