-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(builder): Build IndexesManager on builders #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
refactor/builder-indexes
branch
7 times, most recently
from
June 6, 2023 05:44
23cc018
to
af91a6e
Compare
msbrogli
force-pushed
the
refactor/builder-indexes
branch
from
June 7, 2023 07:43
af91a6e
to
229dac2
Compare
msbrogli
force-pushed
the
refactor/builder-indexes
branch
from
June 7, 2023 07:47
229dac2
to
91a476e
Compare
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 84.07% 83.96% -0.11%
==========================================
Files 245 245
Lines 20282 20295 +13
Branches 2759 2762 +3
==========================================
- Hits 17052 17041 -11
- Misses 2635 2657 +22
- Partials 595 597 +2
|
glevco
previously approved these changes
Jun 9, 2023
jansegre
previously approved these changes
Jun 13, 2023
msbrogli
force-pushed
the
refactor/builder-indexes
branch
from
June 13, 2023 18:49
91a476e
to
512ac62
Compare
jansegre
approved these changes
Jun 13, 2023
glevco
approved these changes
Jun 13, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance criteria
IndexesManager
on builders.Metrics.tx_storage
.