Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feature-activation): implement caching mechanism #645

Merged
merged 2 commits into from
Jun 16, 2023
Merged

feat(feature-activation): implement caching mechanism #645

merged 2 commits into from
Jun 16, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 1, 2023 •
edited
Loading

Acceptance Criteria

  • Implement TransactionMetadata.feature_states attribute
  • Implement Block.get_feature_state() and Block.update_feature_state() methods
  • Implement feature state caching in FeatureService using block metadata

Resolves #630

@glevco glevco self-assigned this Jun 1, 2023
@glevco glevco changed the title WIP feat(feature-activation): implement caching mechanism Jun 1, 2023
@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from 22bfb5d to d7ecf4c Compare June 1, 2023 22:58
@glevco glevco force-pushed the feat/feature-activation/block-ancestor-optimization branch from ab2e73e to bb2aa75 Compare June 2, 2023 03:22
@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from d7ecf4c to d3f58e0 Compare June 2, 2023 03:23
@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #645 (c050c14) into master (6eaedc5) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   83.90%   84.09%   +0.19%     
==========================================
  Files         246      246              
  Lines       20390    20415      +25     
  Branches     2749     2754       +5     
==========================================
+ Hits        17108    17168      +60     
+ Misses       2709     2673      -36     
- Partials      573      574       +1
Impacted Files Coverage Δ
hathor/feature_activation/feature_service.py 97.36% <100.00%> (+0.14%) ⬆️
hathor/transaction/block.py 92.24% <100.00%> (+0.46%) ⬆️
hathor/transaction/transaction_metadata.py 91.12% <100.00%> (+0.44%) ⬆️

... and 8 files with indirect coverage changes

@glevco glevco mentioned this pull request Jun 5, 2023
Merged
msbrogli
msbrogli previously approved these changes Jun 5, 2023
View reviewed changes
hathor/simulator/simulator.py Outdated Show resolved Hide resolved
@glevco glevco force-pushed the feat/feature-activation/block-ancestor-optimization branch from bb2aa75 to 424a933 Compare June 5, 2023 20:40
@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from d3f58e0 to 347472d Compare June 5, 2023 21:12
jansegre
jansegre previously approved these changes Jun 7, 2023
View reviewed changes
@glevco glevco force-pushed the feat/feature-activation/block-ancestor-optimization branch from 424a933 to f4aa6df Compare June 7, 2023 16:07
@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from 347472d to 99c47b4 Compare June 7, 2023 21:13
@glevco glevco requested review from jansegre and msbrogli June 7, 2023 21:14
@glevco glevco force-pushed the feat/feature-activation/block-ancestor-optimization branch from f4aa6df to c7639d2 Compare June 9, 2023 20:35
@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from 99c47b4 to 028ee69 Compare June 9, 2023 20:41
@glevco glevco mentioned this pull request Jun 9, 2023
Merged
@luislhl luislhl mentioned this pull request Jun 14, 2023
Merged
@glevco glevco force-pushed the feat/feature-activation/block-ancestor-optimization branch 7 times, most recently from 1b1333b to 827f003 Compare June 15, 2023 15:53
Base automatically changed from feat/feature-activation/block-ancestor-optimization to master June 15, 2023 15:57
@msbrogli msbrogli dismissed stale reviews from jansegre and themself June 15, 2023 15:57

The base branch was changed.

@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from 5565046 to eb0c4cf Compare June 16, 2023 16:16
@glevco glevco marked this pull request as ready for review June 16, 2023 16:17
jansegre
jansegre previously approved these changes Jun 16, 2023
View reviewed changes
@glevco glevco merged commit 2aead42 into master Jun 16, 2023
@glevco glevco deleted the feat/feature-activation/caching-mechanism branch June 16, 2023 21:22
@jansegre jansegre mentioned this pull request Jul 12, 2023
Merged
2 tasks
This was referenced Aug 2, 2023
Closed
Merged
@glevco glevco mentioned this pull request Oct 31, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansegre jansegre jansegre approved these changes

@msbrogli msbrogli msbrogli approved these changes

Assignees

@glevco glevco

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Activation] Implement caching mechanism
3 participants
@glevco @msbrogli @jansegre