Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(events): improve events during the load phase #652

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 5, 2023

Acceptance Criteria

  • Change handling of events during the load phase, so it's not async anymore
    • Remove HathorEvents.LOAD_FINISHED as it's no used anymore
  • Add progress tracker for handling of load phase events
  • Implement EventStorage.save_events()

@glevco glevco self-assigned this Jun 5, 2023
@glevco glevco changed the title chore: events during the load phase improvements chore(reliable-integration): improve events during the load phase Jun 5, 2023
@glevco glevco changed the title chore(reliable-integration): improve events during the load phase chore(events): improve events during the load phase Jun 5, 2023
@glevco glevco added the enhancement New feature or request label Jun 5, 2023
@glevco glevco changed the title chore(events): improve events during the load phase refactor(events): improve events during the load phase Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #652 (12c7d64) into master (1d5227c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   84.09%   84.11%   +0.01%     
==========================================
  Files         246      246              
  Lines       20418    20442      +24     
  Branches     2754     2757       +3     
==========================================
+ Hits        17170    17194      +24     
  Misses       2674     2674              
  Partials      574      574              
Impacted Files Coverage Δ
hathor/event/model/event_type.py 100.00% <ø> (ø)
hathor/pubsub.py 95.94% <ø> (-0.06%) ⬇️
hathor/event/event_manager.py 91.66% <100.00%> (+0.84%) ⬆️
hathor/event/storage/event_storage.py 100.00% <100.00%> (ø)
hathor/event/storage/memory_storage.py 100.00% <100.00%> (ø)
hathor/event/storage/rocksdb_storage.py 94.68% <100.00%> (+0.49%) ⬆️
hathor/manager.py 77.25% <100.00%> (+0.03%) ⬆️

@glevco glevco force-pushed the tests/event-simulation branch from 70b4556 to 0a62b45 Compare June 5, 2023 21:14
@glevco glevco force-pushed the chore/load-events-improvements branch from 438725b to 5142748 Compare June 5, 2023 21:15
@glevco glevco force-pushed the tests/event-simulation branch 2 times, most recently from 5e114e1 to 7059ee6 Compare June 7, 2023 22:53
@glevco glevco force-pushed the chore/load-events-improvements branch from 5142748 to 95e3435 Compare June 7, 2023 23:04
@glevco glevco force-pushed the tests/event-simulation branch from 7059ee6 to 4dc7623 Compare June 9, 2023 20:47
@glevco glevco force-pushed the chore/load-events-improvements branch from 95e3435 to 392c44e Compare June 9, 2023 20:51
@glevco glevco force-pushed the tests/event-simulation branch from 4dc7623 to 90ddacc Compare June 14, 2023 19:07
@glevco glevco force-pushed the chore/load-events-improvements branch from 0d46584 to 24c1250 Compare June 14, 2023 19:10
@glevco glevco force-pushed the tests/event-simulation branch from 90ddacc to 8fd4a08 Compare June 14, 2023 20:26
@glevco glevco force-pushed the chore/load-events-improvements branch from 24c1250 to f572ec0 Compare June 14, 2023 20:27
@glevco glevco force-pushed the tests/event-simulation branch from 8fd4a08 to 4605d97 Compare June 15, 2023 14:12
@glevco glevco force-pushed the chore/load-events-improvements branch from f572ec0 to 8b4f46f Compare June 15, 2023 14:14
@glevco glevco force-pushed the tests/event-simulation branch from 4605d97 to 441c255 Compare June 15, 2023 15:21
Base automatically changed from tests/event-simulation to master June 15, 2023 15:25
@glevco glevco force-pushed the chore/load-events-improvements branch from 8b4f46f to ed042d3 Compare June 15, 2023 16:07
@glevco glevco marked this pull request as ready for review June 15, 2023 16:11
@glevco glevco requested review from jansegre and msbrogli as code owners June 15, 2023 16:11
@glevco glevco force-pushed the chore/load-events-improvements branch 2 times, most recently from 72bc871 to 912adfd Compare June 16, 2023 15:53
@glevco glevco force-pushed the chore/load-events-improvements branch from 912adfd to fac572e Compare June 16, 2023 21:36
@glevco glevco force-pushed the chore/load-events-improvements branch from fac572e to 12c7d64 Compare June 20, 2023 16:25
@glevco glevco merged commit 21443ac into master Jun 26, 2023
@glevco glevco deleted the chore/load-events-improvements branch June 26, 2023 16:26
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants