-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(events): improve events during the load phase #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
changed the title
chore: events during the load phase improvements
chore(reliable-integration): improve events during the load phase
Jun 5, 2023
glevco
changed the title
chore(reliable-integration): improve events during the load phase
chore(events): improve events during the load phase
Jun 5, 2023
glevco
changed the title
chore(events): improve events during the load phase
refactor(events): improve events during the load phase
Jun 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 84.09% 84.11% +0.01%
==========================================
Files 246 246
Lines 20418 20442 +24
Branches 2754 2757 +3
==========================================
+ Hits 17170 17194 +24
Misses 2674 2674
Partials 574 574
|
glevco
force-pushed
the
tests/event-simulation
branch
from
June 5, 2023 21:14
70b4556
to
0a62b45
Compare
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 5, 2023 21:15
438725b
to
5142748
Compare
glevco
force-pushed
the
tests/event-simulation
branch
2 times, most recently
from
June 7, 2023 22:53
5e114e1
to
7059ee6
Compare
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 7, 2023 23:04
5142748
to
95e3435
Compare
glevco
force-pushed
the
tests/event-simulation
branch
from
June 9, 2023 20:47
7059ee6
to
4dc7623
Compare
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 9, 2023 20:51
95e3435
to
392c44e
Compare
glevco
force-pushed
the
tests/event-simulation
branch
from
June 14, 2023 19:07
4dc7623
to
90ddacc
Compare
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 14, 2023 19:10
0d46584
to
24c1250
Compare
glevco
force-pushed
the
tests/event-simulation
branch
from
June 14, 2023 20:26
90ddacc
to
8fd4a08
Compare
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 14, 2023 20:27
24c1250
to
f572ec0
Compare
glevco
force-pushed
the
tests/event-simulation
branch
from
June 15, 2023 14:12
8fd4a08
to
4605d97
Compare
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 15, 2023 14:14
f572ec0
to
8b4f46f
Compare
glevco
force-pushed
the
tests/event-simulation
branch
from
June 15, 2023 15:21
4605d97
to
441c255
Compare
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 15, 2023 16:07
8b4f46f
to
ed042d3
Compare
glevco
force-pushed
the
chore/load-events-improvements
branch
2 times, most recently
from
June 16, 2023 15:53
72bc871
to
912adfd
Compare
msbrogli
requested changes
Jun 16, 2023
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 16, 2023 21:36
912adfd
to
fac572e
Compare
msbrogli
approved these changes
Jun 20, 2023
glevco
force-pushed
the
chore/load-events-improvements
branch
from
June 20, 2023 16:25
fac572e
to
12c7d64
Compare
jansegre
approved these changes
Jun 26, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
HathorEvents.LOAD_FINISHED
as it's no used anymoreEventStorage.save_events()