refactor: Change HathorManager.on_new_tx() to accept only fully validated transactions #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
refactor/clean-on-new-tx
branch
from
1202c3c to
f92859c
Compare
jansegre
previously approved these changes
Jun 14, 2023
msbrogli
force-pushed
the
refactor/clean-on-new-tx
branch
2 times, most recently
from
c4b2393 to
726cdc0
Compare
…ated transactions
msbrogli
force-pushed
the
refactor/clean-on-new-tx
branch
from
726cdc0 to
ae81b27
Compare
jansegre
approved these changes
Jun 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance criteria
HathorManager.on_new_tx()to accept only fully validated transactions.HathorManager.log_new_object()to log new vertices.