Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings initialization #666

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 14, 2023

Acceptance Criteria

  • Fix import order that was causing a settings initialization issue

@glevco glevco added the bug Something isn't working label Jun 14, 2023
@glevco glevco self-assigned this Jun 14, 2023
@glevco glevco marked this pull request as ready for review June 14, 2023 18:24
@glevco glevco requested review from jansegre and msbrogli as code owners June 14, 2023 18:24
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #666 (89a001c) into master (ea7b859) will increase coverage by 0.07%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   83.78%   83.85%   +0.07%     
==========================================
  Files         246      247       +1     
  Lines       20309    20399      +90     
  Branches     2753     2757       +4     
==========================================
+ Hits        17016    17106      +90     
- Misses       2711     2712       +1     
+ Partials      582      581       -1     
Impacted Files Coverage Δ
hathor/transaction/block.py 91.78% <60.00%> (-0.28%) ⬇️
hathor/indexes/deps_index.py 90.56% <66.66%> (+0.18%) ⬆️
hathor/manager.py 73.97% <72.72%> (-0.23%) ⬇️
hathor/builder/builder.py 92.97% <100.00%> (+0.10%) ⬆️
hathor/builder/resources_builder.py 94.39% <100.00%> (+0.16%) ⬆️
hathor/consensus/block_consensus.py 94.36% <100.00%> (+0.01%) ⬆️
hathor/consensus/consensus.py 100.00% <100.00%> (ø)
hathor/daa.py 95.49% <100.00%> (ø)
hathor/feature_activation/feature_service.py 96.87% <100.00%> (+0.04%) ⬆️
hathor/feature_activation/model/criteria.py 100.00% <100.00%> (ø)
... and 10 more

... and 3 files with indirect coverage changes

@msbrogli msbrogli merged commit 89a001c into master Jun 14, 2023
@msbrogli msbrogli deleted the fix/settings-initialization branch June 14, 2023 19:59
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants