Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is in preparation for PubSub changes in #694. The current implementation of the
test_p2p_network_events()
test,hathor-core/tests/others/test_metrics.py
Lines 68 to 69 in 0dd129d
Tries to start a connection, which fails because the reactor used in tests (
Clock
) doesn't support TCP connections. This fail is expected and triggers the emission of the PubSubNETWORK_PEER_CONNECTION_FAILURE
event, which is what triggers theMetrics
update, making the test work.In #694, the
Clock
is getting changed to aMemoryReactorClock
, which does support TCP connections (but doesn't complete them), so theNETWORK_PEER_CONNECTION_FAILURE
is not triggered.We add an almost effectless new
NETWORK_PEER_CONNECTING
event that gets triggered when the peers starts connecting, so theMetrics
update is still triggered.Acceptance Criteria
HathorEvents.NETWORK_PEER_CONNECTING
eventMetrics
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged