chore(extras): script to generate list of PRs that master is ahead of rc #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
previously approved these changes
Jul 12, 2023
| @@ -0,0 +1,64 @@ | |||
| #!/bin/env python | |||
There was a problem hiding this comment.
Add some docs on how to execute and give an example of output.
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 84.11% 84.12% +0.01%
==========================================
Files 246 246
Lines 20448 20450 +2
Branches 2760 2760
==========================================
+ Hits 17200 17204 +4
+ Misses 2674 2673 -1
+ Partials 574 573 -1 |
jansegre
force-pushed
the
chore/gen-rc-prs-script
branch
from
f7f6787 to
f3a9ce6
Compare
luislhl
reviewed
Jul 12, 2023
| @@ -0,0 +1,79 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
We need a way for people doing releases to know that this exists (in case someone else needs to do them)
I think we should guide them to use this in our release guide.
What do you think?
luislhl
approved these changes
Jul 12, 2023
jansegre
force-pushed
the
chore/gen-rc-prs-script
branch
from
f3a9ce6 to
32ae482
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Getting the list of PRs to include in the release-candidate description was getting cumbersome and error prone.
Acceptance Criteria
extrasthat will generate a markdown list of PRs to be used when creating a new release-candidateghto be installed and authenticated in order to use Github's APIChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged