Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature-activation): implement bit signaling service #702

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jul 14, 2023

Motivation

This PR implements the BitSignalingService as defined in this RFC.

Acceptance Criteria

  • Add --signal-support and --signal-not-support CLI options
  • Add Criteria.signal_support_by_default attribute
  • Add FeatureState.get_signaling_states() method
  • Implement BitSignalingService

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco marked this pull request as ready for review July 14, 2023 01:22
@glevco glevco requested review from jansegre and msbrogli as code owners July 14, 2023 01:22
@glevco glevco marked this pull request as draft July 14, 2023 01:22
@glevco glevco force-pushed the feat/feature-activation/bit-signaling-service branch from 6a507b4 to a2c0210 Compare July 14, 2023 01:27
@glevco glevco self-assigned this Jul 14, 2023
@glevco glevco force-pushed the feat/feature-activation/bit-signaling-service branch from a2c0210 to 522ffbd Compare July 14, 2023 01:33
@glevco glevco marked this pull request as ready for review July 14, 2023 02:06
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #702 (9176efb) into master (779494c) will decrease coverage by 0.02%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
- Coverage   84.00%   83.99%   -0.02%     
==========================================
  Files         246      247       +1     
  Lines       20517    20589      +72     
  Branches     2769     2779      +10     
==========================================
+ Hits        17236    17294      +58     
- Misses       2707     2716       +9     
- Partials      574      579       +5     
Impacted Files Coverage Δ
hathor/feature_activation/bit_signaling_service.py 83.60% <83.60%> (ø)
hathor/feature_activation/feature.py 100.00% <100.00%> (ø)
hathor/feature_activation/model/criteria.py 100.00% <100.00%> (ø)
hathor/feature_activation/model/feature_state.py 100.00% <100.00%> (ø)
hathor/feature_activation/settings.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

jansegre
jansegre previously approved these changes Jul 17, 2023
@glevco glevco force-pushed the feat/feature-activation/bit-signaling-service branch from 8c7be67 to 4ab2466 Compare July 18, 2023 01:09
@glevco glevco changed the base branch from master to fix/feature-activation/criteria-validation July 18, 2023 01:09
@glevco glevco marked this pull request as draft July 18, 2023 01:14
jansegre
jansegre previously approved these changes Jul 18, 2023
@glevco glevco force-pushed the fix/feature-activation/criteria-validation branch from 4d1be8e to 454ca26 Compare July 18, 2023 16:11
@glevco glevco force-pushed the feat/feature-activation/bit-signaling-service branch from 4ab2466 to 1092ff1 Compare July 18, 2023 16:44
msbrogli
msbrogli previously approved these changes Jul 19, 2023
hathor/cli/run_node.py Show resolved Hide resolved
hathor/feature_activation/bit_signaling_service.py Outdated Show resolved Hide resolved
Base automatically changed from fix/feature-activation/criteria-validation to master July 19, 2023 17:44
@glevco glevco dismissed stale reviews from msbrogli and jansegre July 19, 2023 17:44

The base branch was changed.

@glevco glevco force-pushed the feat/feature-activation/bit-signaling-service branch from 0519850 to 9176efb Compare July 19, 2023 17:47
@glevco glevco marked this pull request as ready for review July 19, 2023 17:55
@glevco glevco merged commit c770612 into master Jul 19, 2023
@glevco glevco deleted the feat/feature-activation/bit-signaling-service branch July 19, 2023 19:35
@jansegre jansegre mentioned this pull request Jul 24, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants