-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add best_blockchain in /status payload #704
Merged
alexruzenhack
merged 5 commits into
master
from
feat/status-best-blockchain-in-connected-peers
Aug 10, 2023
Merged
feat: add best_blockchain in /status payload #704
alexruzenhack
merged 5 commits into
master
from
feat/status-best-blockchain-in-connected-peers
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
from
July 14, 2023 02:41
0eef461
to
d3c3a3a
Compare
alexruzenhack
changed the base branch from
master
to
feat/add-get-best-blockchain-capability
July 14, 2023 16:43
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
from
July 17, 2023 19:04
d3c3a3a
to
b5a1084
Compare
msbrogli
requested changes
Jul 18, 2023
alexruzenhack
force-pushed
the
feat/add-get-best-blockchain-capability
branch
3 times, most recently
from
July 18, 2023 18:53
32d03de
to
ff89803
Compare
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
from
July 18, 2023 22:09
b5a1084
to
d75e0ec
Compare
alexruzenhack
force-pushed
the
feat/add-get-best-blockchain-capability
branch
2 times, most recently
from
July 19, 2023 01:34
887e94c
to
53e6b6d
Compare
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
2 times, most recently
from
July 19, 2023 02:15
ce42303
to
cbe6045
Compare
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 84.52% 84.61% +0.08%
==========================================
Files 253 252 -1
Lines 21708 21717 +9
Branches 2941 2941
==========================================
+ Hits 18349 18376 +27
+ Misses 2718 2705 -13
+ Partials 641 636 -5
|
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
from
July 19, 2023 17:06
cbe6045
to
4924993
Compare
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
2 times, most recently
from
July 19, 2023 17:48
8e01316
to
1a9a59a
Compare
alexruzenhack
commented
Jul 19, 2023
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
from
July 19, 2023 21:31
1a9a59a
to
dace9f9
Compare
alexruzenhack
force-pushed
the
feat/add-get-best-blockchain-capability
branch
from
July 20, 2023 16:14
53e6b6d
to
4906761
Compare
alexruzenhack
force-pushed
the
feat/add-get-best-blockchain-capability
branch
from
July 27, 2023 14:17
d234777
to
4752c03
Compare
msbrogli
force-pushed
the
feat/add-get-best-blockchain-capability
branch
from
July 27, 2023 21:09
b41bcca
to
949d09c
Compare
alexruzenhack
force-pushed
the
feat/add-get-best-blockchain-capability
branch
2 times, most recently
from
July 27, 2023 21:22
e05fdaf
to
78d3fad
Compare
Base automatically changed from
feat/add-get-best-blockchain-capability
to
master
July 28, 2023 12:17
alexruzenhack
dismissed stale reviews from msbrogli and jansegre
July 28, 2023 12:17
The base branch was changed.
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
2 times, most recently
from
July 28, 2023 13:30
08f5079
to
06644a8
Compare
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
from
July 28, 2023 13:36
06644a8
to
a3318d4
Compare
msbrogli
requested changes
Aug 1, 2023
msbrogli
previously approved these changes
Aug 3, 2023
alexruzenhack
force-pushed
the
feat/status-best-blockchain-in-connected-peers
branch
from
August 3, 2023 16:36
6dcc3a4
to
8ab76c4
Compare
jansegre
approved these changes
Aug 3, 2023
pedroferreira1
approved these changes
Aug 9, 2023
alexruzenhack
deleted the
feat/status-best-blockchain-in-connected-peers
branch
August 10, 2023 21:48
This was referenced Aug 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Expose the best_blockchain through an interface.
Acceptance Criteria
peer_best_blockchain
property in the connected_peer body when/status
is requestedbest_blockchain
property in the dag when/status
is requestedChecklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets mergedCloses: