refactor(sync-v2): improve deferreds handling #732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simplify deferred-handling code by removing repetition and improving typing robustness.
Acceptance Criteria
tips
,best-block
, andpeer-block-hashes
), by using a specific, typed attribute for each of them, instead of storing them in a generic dictionary.VertexId
, so theorigin
is removed from it.None
handling inget_tx()
fromif/raise
toassert
, as the typing guaranteestx
will never beNone
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged