Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): add setting to enable/disable peer whitelist for sync-v2 #735

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jansegre
Copy link
Member

Motivation

While sync-v2 is in beta it's better to keep using the whitelist until it is stable.

Acceptance Criteria

  • Add a bool option to the settings to choose whether the peer whitelist should be considered for sync-v2 peers

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Jul 27, 2023
@jansegre jansegre requested a review from msbrogli as a code owner July 27, 2023 19:29
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #735 (e710e6d) into master (91590c7) will decrease coverage by 0.09%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
- Coverage   84.52%   84.43%   -0.09%     
==========================================
  Files         251      251              
  Lines       21603    21607       +4     
  Branches     2921     2923       +2     
==========================================
- Hits        18259    18244      -15     
- Misses       2710     2724      +14     
- Partials      634      639       +5     
Files Changed Coverage Δ
hathor/p2p/states/peer_id.py 71.11% <20.00%> (-2.46%) ⬇️
hathor/conf/settings.py 97.08% <100.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

@jansegre jansegre merged commit 338b3ef into master Jul 27, 2023
@jansegre jansegre deleted the feat/whitelist-for-sync-v2 branch July 27, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants