tests: decrease tests duration #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
previously approved these changes
Aug 24, 2023
jansegre
previously approved these changes
Aug 24, 2023
glevco
force-pushed
the
tests/decrease_tests_duration
branch
from
4a0cd00 to
925fe90
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 84.73% 84.74% +0.01%
==========================================
Files 259 259
Lines 21912 21912
Branches 2963 2963
==========================================
+ Hits 18567 18570 +3
+ Misses 2698 2696 -2
+ Partials 647 646 -1 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
tests/decrease_tests_duration
branch
from
925fe90 to
2fdc1d0
Compare
jansegre
reviewed
Sep 1, 2023
@jansegre yes, it's just my bad luck. Only one passed, actually, 3.11 on Windows. I'll rerun them anyway |
@jansegre I don't think so, I've looked at the failures and it looks like they're all either from the |
jansegre
approved these changes
Sep 4, 2023
msbrogli
approved these changes
Sep 6, 2023
glevco
force-pushed
the
tests/decrease_tests_duration
branch
from
2fdc1d0 to
a847f51
Compare
This was referenced Oct 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #753 introduced the new
pause_after_exactly()miner simulator ability, and changed Feature Activation mining simulation tests to use it instead of theStopAfterNMinedBlocks, removing flakiness. Since the trigger was removed, the test running times were unnecessarily too long.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged