Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imports #762

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: imports #762

merged 1 commit into from
Aug 29, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Aug 28, 2023

Motivation

There's an incorrect import preventing full node initialization.

Acceptance Criteria

  • Fix import

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #762 (7265310) into master (29d9ec3) will decrease coverage by 0.09%.
Report is 4 commits behind head on master.
The diff coverage is 87.83%.

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   84.70%   84.62%   -0.09%     
==========================================
  Files         252      253       +1     
  Lines       21801    21822      +21     
  Branches     2954     2957       +3     
==========================================
- Hits        18467    18466       -1     
- Misses       2692     2708      +16     
- Partials      642      648       +6     
Files Changed Coverage Δ
hathor/sysctl/protocol.py 79.01% <80.76%> (-5.31%) ⬇️
hathor/sysctl/runner.py 90.00% <90.00%> (ø)
hathor/conf/testnet.py 100.00% <100.00%> (ø)
hathor/sysctl/exception.py 100.00% <100.00%> (ø)
hathor/sysctl/factory.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@jansegre jansegre merged commit 99ba548 into master Aug 29, 2023
@jansegre jansegre deleted the fix/imports branch August 29, 2023 20:02
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants