Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reliable-integration): add decoded outputs in event responses #763

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Aug 29, 2023

Motivation

This PR updates the schema of reliable integration events by including extra data about inputs and outputs, requested by our wallet-service use case.

Acceptance Criteria

  • Update event data to include:
    • Decoded outputs
    • Decoded spent outputs of inputs

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Aug 29, 2023
@glevco glevco force-pushed the refactor/event-simulator-cli branch from 8c1b925 to 50deb84 Compare August 30, 2023 15:18
@glevco glevco force-pushed the feat/reliable-integration/decoded-outputs branch 2 times, most recently from 6d50300 to 2c594f1 Compare August 30, 2023 15:29
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (91b2676) 84.73% compared to head (cc35384) 84.71%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   84.73%   84.71%   -0.02%     
==========================================
  Files         259      259              
  Lines       21900    21912      +12     
  Branches     2960     2963       +3     
==========================================
+ Hits        18557    18563       +6     
- Misses       2700     2701       +1     
- Partials      643      648       +5     
Files Changed Coverage Δ
hathor/event/model/event_data.py 100.00% <100.00%> (ø)
hathor/transaction/resources/transaction.py 93.43% <100.00%> (+3.72%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from refactor/event-simulator-cli to master September 1, 2023 19:01
@glevco glevco force-pushed the feat/reliable-integration/decoded-outputs branch from 2c594f1 to 7c92297 Compare September 1, 2023 19:04
@glevco glevco marked this pull request as ready for review September 1, 2023 19:04
@glevco glevco force-pushed the feat/reliable-integration/decoded-outputs branch 5 times, most recently from 0e72d8b to c5172f0 Compare September 1, 2023 21:47
@glevco glevco force-pushed the feat/reliable-integration/decoded-outputs branch from c5172f0 to cc35384 Compare September 8, 2023 16:45
@glevco glevco merged commit 0f78923 into master Sep 11, 2023
@glevco glevco deleted the feat/reliable-integration/decoded-outputs branch September 11, 2023 01:17
This was referenced Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants