feat(wallet): Add BaseWallet.get_balance_per_address() method #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
approved these changes
Sep 25, 2023
andreabadesso
approved these changes
Oct 5, 2023
msbrogli
force-pushed
the
feat/wallet-get_balance_per_address
branch
from
72372e7 to
32da24d
Compare
This was referenced Oct 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Utility method to be used on tests and simulations.
Acceptance Criteria
BaseWallet.get_balance_per_address()that returns the balances grouped by addresses.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged