-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(settings): change HathorManager to use injected settings #787
Conversation
73a4417
to
7782a41
Compare
3c084df
to
a008e7e
Compare
914dd77
to
748afab
Compare
748afab
to
0a9b949
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #787 +/- ##
==========================================
+ Coverage 84.64% 84.69% +0.04%
==========================================
Files 264 264
Lines 22024 22023 -1
Branches 3367 3368 +1
==========================================
+ Hits 18643 18653 +10
+ Misses 2727 2720 -7
+ Partials 654 650 -4
☔ View full report in Codecov by Sentry. |
0a9b949
to
c700dc5
Compare
c700dc5
to
85a3bfc
Compare
Motivation
Continuing with the settings-related refactors, this PR updates
HathorManager
so it starts using injected settings, instead of global. This refactor is necessary for the Feature Activation mandatory signaling implementation.Acceptance Criteria
settings
attribute toHathorManager
, removing the module level settingsDEFAULT_CAPABILITIES
from module level toHathorManager.get_default_capabilities()
Builder
andCliBuilder
accordinglyChecklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged