-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(verification): move verification methods signatures [part 2/5] #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
changed the title
refactor(verification): move verification methods signatures
refactor(verification): move verification methods signatures [part 2]
Sep 29, 2023
1 task
glevco
changed the title
refactor(verification): move verification methods signatures [part 2]
refactor(verification): move verification methods signatures [part 2/5]
Sep 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 84.55% 84.56% +0.01%
==========================================
Files 269 269
Lines 22234 22308 +74
Branches 3397 3401 +4
==========================================
+ Hits 18799 18865 +66
- Misses 2765 2771 +6
- Partials 670 672 +2
☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Oct 3, 2023
glevco
force-pushed
the
refactor/move-verification/create-verifiers
branch
from
October 9, 2023 19:26
8f2d608
to
462f90f
Compare
glevco
force-pushed
the
refactor/move-verification/method-signatures
branch
from
October 9, 2023 19:50
13398a6
to
f407055
Compare
glevco
force-pushed
the
refactor/move-verification/create-verifiers
branch
from
October 9, 2023 23:57
462f90f
to
f35ffce
Compare
glevco
force-pushed
the
refactor/move-verification/method-signatures
branch
from
October 10, 2023 02:29
f407055
to
5b92821
Compare
glevco
force-pushed
the
refactor/move-verification/create-verifiers
branch
from
October 10, 2023 18:57
d43178a
to
1cb8d78
Compare
Base automatically changed from
refactor/move-verification/create-verifiers
to
master
October 10, 2023 20:33
glevco
force-pushed
the
refactor/move-verification/method-signatures
branch
2 times, most recently
from
October 11, 2023 17:36
160989e
to
2c4f61e
Compare
msbrogli
requested changes
Oct 16, 2023
glevco
force-pushed
the
refactor/move-verification/method-signatures
branch
from
October 17, 2023 20:50
2c4f61e
to
105e059
Compare
msbrogli
requested changes
Oct 18, 2023
msbrogli
approved these changes
Oct 18, 2023
jansegre
approved these changes
Oct 18, 2023
glevco
force-pushed
the
refactor/move-verification/method-signatures
branch
from
October 19, 2023 20:29
105e059
to
111621e
Compare
1 task
glevco
force-pushed
the
refactor/move-verification/method-signatures
branch
from
October 24, 2023 19:28
111621e
to
24de4ef
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #796
Motivation
This is the second PR in a 5-part series of PRs that completely move verification-related code out of the vertex model classes.
The objective in this PR is to copy all verification methods signatures from the vertex model classes to each respective
Verifier
class. The new methods simply call the original methods, effectively providing a new interface for existing implementations.By doing this, we can update all callers of any verification method to use the new
Verifier
methods, while not touching the original model classes. This is the scaffolding necessary to actually move method implementations in the following PRs.Acceptance Criteria
Verifier
class. The implementation is simply a forward to the original method implemented by each vertex model class.VerificationService.verify_without_storage()
.Verifier
method, instead of the original model method.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged