-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(verification): move transaction-only verification methods [part 4/5] #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
changed the title
refactor(verification): move transaction-only verification methods [part 4]
refactor(verification): move transaction-only verification methods [part 4/5]
Sep 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
==========================================
- Coverage 84.59% 84.58% -0.02%
==========================================
Files 269 269
Lines 22296 22277 -19
Branches 3401 3401
==========================================
- Hits 18861 18842 -19
Misses 2765 2765
Partials 670 670
☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Oct 3, 2023
glevco
force-pushed
the
refactor/move-verification/block-methods
branch
from
October 10, 2023 02:32
3846066
to
222e32f
Compare
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 10, 2023 02:34
9f2245e
to
422ec12
Compare
glevco
force-pushed
the
refactor/move-verification/block-methods
branch
from
October 10, 2023 02:53
222e32f
to
6039c40
Compare
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 10, 2023 02:53
422ec12
to
48feebd
Compare
glevco
force-pushed
the
refactor/move-verification/block-methods
branch
from
October 10, 2023 20:51
6039c40
to
727b499
Compare
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 10, 2023 20:52
48feebd
to
2bc5ebd
Compare
glevco
force-pushed
the
refactor/move-verification/block-methods
branch
from
October 11, 2023 20:33
31d5d85
to
95e2def
Compare
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 11, 2023 20:34
2bc5ebd
to
4af2cfb
Compare
glevco
force-pushed
the
refactor/move-verification/block-methods
branch
from
October 17, 2023 21:03
95e2def
to
5fd2094
Compare
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 17, 2023 21:09
4af2cfb
to
7407fc6
Compare
glevco
force-pushed
the
refactor/move-verification/block-methods
branch
from
October 19, 2023 20:29
5fd2094
to
2b0c232
Compare
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 19, 2023 20:30
7407fc6
to
c5ae653
Compare
msbrogli
previously approved these changes
Oct 24, 2023
glevco
force-pushed
the
refactor/move-verification/block-methods
branch
from
October 24, 2023 19:50
61cc04b
to
1a5a08a
Compare
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 24, 2023 20:43
c5ae653
to
78890ea
Compare
glevco
force-pushed
the
refactor/move-verification/block-methods
branch
2 times, most recently
from
October 24, 2023 21:45
40baa10
to
94b9075
Compare
Base automatically changed from
refactor/move-verification/block-methods
to
master
October 24, 2023 23:37
glevco
dismissed stale reviews from msbrogli and jansegre
October 24, 2023 23:37
The base branch was changed.
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 24, 2023 23:39
78890ea
to
389903c
Compare
msbrogli
previously approved these changes
Oct 25, 2023
msbrogli
approved these changes
Oct 25, 2023
jansegre
approved these changes
Oct 25, 2023
glevco
force-pushed
the
refactor/move-verification/transaction-methods
branch
from
October 25, 2023 13:51
432abb0
to
2ca6cb6
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #798
Motivation
This is the fourth PR in a 5-part series of PRs that completely move verification-related code out of the vertex model classes.
This PR moves the verification method implementations of the
Transaction
inheritance branch.Acceptance Criteria
Transaction
andTokenCreationTransaction
verification methods from the original model classes, moving the implementation to each respectiveVerifier
class. The only exception is theverify_outputs()
method, which is part of the inheritance tree up toBaseTransaction
, and will be moved in a separate PR.check_authorities_and_deposit()
is renamed toverify_authorities_and_deposit()
, for consistency.update_token_info_from_outputs()
is also moved as it's only used by verification.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged