Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reliable-integration): update peer metadata schema #804

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 2, 2023

Motivation

Our reliable integration use case (wallet service) suggested that the peer_id attribute could be moved on the event schema, and also that network should be included.

Acceptance Criteria

  • Move peer_id upwards in the event schema.
  • Add network to the event schema.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 2, 2023
@glevco glevco marked this pull request as ready for review October 2, 2023 19:00
@glevco glevco force-pushed the feat/reliable-integration/event-schema branch from f156541 to 4687a5f Compare October 3, 2023 14:41
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ab1a6ca) 84.63% compared to head (5a0a15a) 84.59%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
- Coverage   84.63%   84.59%   -0.04%     
==========================================
  Files         270      271       +1     
  Lines       22290    22311      +21     
  Branches     3404     3406       +2     
==========================================
+ Hits        18865    18874       +9     
- Misses       2757     2768      +11     
- Partials      668      669       +1     
Files Coverage Δ
hathor/builder/builder.py 91.30% <100.00%> (+0.04%) ⬆️
hathor/builder/cli_builder.py 74.48% <100.00%> (ø)
hathor/event/event_manager.py 91.60% <ø> (ø)
hathor/event/model/base_event.py 100.00% <ø> (ø)
hathor/event/websocket/factory.py 93.33% <100.00%> (+0.22%) ⬆️
hathor/event/websocket/response.py 100.00% <100.00%> (ø)
hathor/feature_activation/bit_signaling_service.py 85.24% <ø> (ø)
hathor/manager.py 80.73% <100.00%> (ø)
hathor/transaction/storage/transaction_storage.py 93.04% <100.00%> (ø)
...ions/add_feature_activation_bit_counts_metadata.py 68.75% <68.75%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/reliable-integration/event-schema branch from 4687a5f to 40cd36f Compare October 10, 2023 03:36
jansegre
jansegre previously approved these changes Oct 10, 2023
@glevco glevco marked this pull request as draft October 10, 2023 21:09
@glevco glevco force-pushed the feat/reliable-integration/event-schema branch from 40cd36f to bfd7044 Compare October 11, 2023 20:38
@glevco glevco marked this pull request as ready for review October 11, 2023 20:39
@glevco glevco force-pushed the feat/reliable-integration/event-schema branch 2 times, most recently from 0e83680 to 4e0a25b Compare October 19, 2023 20:28
@glevco glevco force-pushed the feat/reliable-integration/event-schema branch 3 times, most recently from 396dd02 to 3c006a0 Compare October 25, 2023 17:25
@glevco glevco force-pushed the feat/reliable-integration/event-schema branch 2 times, most recently from 1c76d8d to 5fabba2 Compare October 27, 2023 16:48
@glevco glevco force-pushed the feat/reliable-integration/event-schema branch from 5fabba2 to 5a0a15a Compare October 28, 2023 03:26
@glevco glevco merged commit bf0d0bc into master Oct 28, 2023
@glevco glevco deleted the feat/reliable-integration/event-schema branch October 28, 2023 16:00
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants