-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reliable-integration): update peer metadata schema #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/reliable-integration/event-schema
branch
from
October 3, 2023 14:41
f156541
to
4687a5f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
==========================================
- Coverage 84.63% 84.59% -0.04%
==========================================
Files 270 271 +1
Lines 22290 22311 +21
Branches 3404 3406 +2
==========================================
+ Hits 18865 18874 +9
- Misses 2757 2768 +11
- Partials 668 669 +1
☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
feat/reliable-integration/event-schema
branch
from
October 10, 2023 03:36
4687a5f
to
40cd36f
Compare
jansegre
previously approved these changes
Oct 10, 2023
glevco
force-pushed
the
feat/reliable-integration/event-schema
branch
from
October 11, 2023 20:38
40cd36f
to
bfd7044
Compare
glevco
force-pushed
the
feat/reliable-integration/event-schema
branch
2 times, most recently
from
October 19, 2023 20:28
0e83680
to
4e0a25b
Compare
glevco
force-pushed
the
feat/reliable-integration/event-schema
branch
3 times, most recently
from
October 25, 2023 17:25
396dd02
to
3c006a0
Compare
msbrogli
approved these changes
Oct 27, 2023
jansegre
approved these changes
Oct 27, 2023
glevco
force-pushed
the
feat/reliable-integration/event-schema
branch
2 times, most recently
from
October 27, 2023 16:48
1c76d8d
to
5fabba2
Compare
glevco
force-pushed
the
feat/reliable-integration/event-schema
branch
from
October 28, 2023 03:26
5fabba2
to
5a0a15a
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our reliable integration use case (wallet service) suggested that the
peer_id
attribute could be moved on the event schema, and also thatnetwork
should be included.Acceptance Criteria
peer_id
upwards in the event schema.network
to the event schema.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged