Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use INFO as default log level to reduce amount of logs #814

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Oct 17, 2023

Motivation

Current log size is too big when a test fails. It's so big that it does not provide any help to understand what went wrong.

Acceptance Criteria

  1. Print seed using INFO log level.
  2. Set INFO as default log level for both sync-v1 and sync-v2 even when debugging is enabled.
  3. Change default log level for INFO for all tests.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner October 17, 2023 22:44
@msbrogli msbrogli requested a review from glevco October 17, 2023 22:44
@msbrogli msbrogli self-assigned this Oct 17, 2023
@msbrogli msbrogli added the tests label Oct 17, 2023
@msbrogli msbrogli merged commit 59903bc into master Oct 18, 2023
@msbrogli msbrogli deleted the test/info-log-level branch October 18, 2023 15:30
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants