Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mining): Wrong timestamp sent to _make_block_template #823

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Oct 20, 2023

Motivation

PR #822 was not enough to fix the flaky tests because the caller of _make_block_template() was sending the wrong current_timestamp.

Acceptance Criteria

  1. Fix the calculation of current_timestamp in HathorManager.make_block_template().

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli self-assigned this Oct 20, 2023
@msbrogli msbrogli requested a review from jansegre as a code owner October 20, 2023 21:41
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cee806) 84.55% compared to head (25b3983) 84.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
- Coverage   84.55%   84.51%   -0.05%     
==========================================
  Files         269      269              
  Lines       22234    22234              
  Branches     3397     3397              
==========================================
- Hits        18800    18791       -9     
- Misses       2765     2770       +5     
- Partials      669      673       +4     
Files Coverage Δ
hathor/manager.py 80.73% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msbrogli msbrogli merged commit 25b3983 into master Oct 23, 2023
@msbrogli msbrogli deleted the fix/block-template-timestamp-2 branch October 23, 2023 22:09
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants