Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #840

Merged
merged 1 commit into from
Oct 28, 2023
Merged

chore: update dependencies #840

merged 1 commit into from
Oct 28, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 27, 2023

Motivation

Update dependencies to improve static analysis and developer experience.

Acceptance Criteria

  • Update all dev-dependencies.
  • Update Pydantic.
  • Fix some new linter issues.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89d347e) 84.58% compared to head (55a95d9) 84.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files         270      270           
  Lines       22290    22290           
  Branches     3404     3404           
=======================================
+ Hits        18854    18855    +1     
+ Misses       2765     2764    -1     
  Partials      671      671           
Files Coverage Δ
hathor/event/model/base_event.py 100.00% <100.00%> (ø)
hathor/p2p/utils.py 74.10% <100.00%> (ø)
hathor/utils/named_tuple.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review October 27, 2023 16:12
msbrogli
msbrogli previously approved these changes Oct 27, 2023
hathor/utils/named_tuple.py Outdated Show resolved Hide resolved
@glevco glevco force-pushed the chore/update-dependencies branch from ce0a577 to 0441334 Compare October 27, 2023 20:07
@glevco glevco force-pushed the chore/update-dependencies branch from 0441334 to 55a95d9 Compare October 27, 2023 21:44
@glevco glevco merged commit ab1a6ca into master Oct 28, 2023
9 checks passed
@glevco glevco deleted the chore/update-dependencies branch October 28, 2023 00:31
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants