-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sync-v2): Fix n-ary search to handle reorgs during its execution #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
==========================================
+ Coverage 84.61% 85.01% +0.40%
==========================================
Files 271 271
Lines 22311 22368 +57
Branches 3406 3420 +14
==========================================
+ Hits 18878 19017 +139
+ Misses 2764 2675 -89
- Partials 669 676 +7
☔ View full report in Codecov by Sentry. |
glevco
requested changes
Oct 27, 2023
jansegre
previously approved these changes
Oct 30, 2023
msbrogli
force-pushed
the
fix/sync-v2-n-ary-search
branch
2 times, most recently
from
October 30, 2023 18:27
e907099
to
f345346
Compare
jansegre
previously approved these changes
Oct 30, 2023
msbrogli
force-pushed
the
fix/sync-v2-n-ary-search
branch
3 times, most recently
from
November 3, 2023 00:56
f5d6e6b
to
dcb0e77
Compare
msbrogli
force-pushed
the
fix/sync-v2-n-ary-search
branch
from
November 3, 2023 03:20
dcb0e77
to
c47f06e
Compare
jansegre
approved these changes
Nov 3, 2023
glevco
approved these changes
Nov 3, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The n-ary search executed by sync-v2 was not taking into consideration that a reorg might occur during the search as it runs multiple async queries on the connected peer.
Acceptance Criteria
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged