Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simulator): Add StopWhenSendLineMatch trigger #847

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Nov 3, 2023

Motivation

This trigger gives control to stop the simulator when a given message is sent from one node to another.

Acceptance Criteria

  1. Add StopWhenSendLineMatch trigger which monitors a connection and stops the simulator when a message matches a regex pattern.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli added the enhancement New feature or request label Nov 3, 2023
@msbrogli msbrogli self-assigned this Nov 3, 2023
@msbrogli msbrogli requested a review from jansegre as a code owner November 3, 2023 03:08
hathor/simulator/trigger.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e09351c) 85.26% compared to head (2cc841b) 85.32%.
Report is 4 commits behind head on master.

❗ Current head 2cc841b differs from pull request most recent head 7b6eb34. Consider uploading reports for the commit 7b6eb34 to get more accurate results

Files Patch % Lines
hathor/simulator/trigger.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   85.26%   85.32%   +0.05%     
==========================================
  Files         281      281              
  Lines       22363    22380      +17     
  Branches     3388     3390       +2     
==========================================
+ Hits        19068    19095      +27     
+ Misses       2608     2604       -4     
+ Partials      687      681       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jansegre
jansegre previously approved these changes Nov 3, 2023
@msbrogli msbrogli requested a review from glevco November 3, 2023 15:49
@msbrogli msbrogli force-pushed the feat/trigger-sendline-regex branch from c0f2c6e to d9d322a Compare November 6, 2023 19:53
@jansegre jansegre force-pushed the feat/trigger-sendline-regex branch from d9d322a to 2cc841b Compare November 21, 2023 16:00
@msbrogli msbrogli force-pushed the feat/trigger-sendline-regex branch from 2cc841b to 8a6abb5 Compare November 24, 2023 15:04
@msbrogli msbrogli merged commit 7b6eb34 into master Nov 24, 2023
8 checks passed
@msbrogli msbrogli deleted the feat/trigger-sendline-regex branch November 24, 2023 15:19
@jansegre jansegre mentioned this pull request Nov 24, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants