-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync-v2): Add both BlockchainStreamingClient and TransactionStreamingClient to manage streamings from the client side #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
feat/sync-v2-improvements-3
branch
4 times, most recently
from
November 3, 2023 07:07
0b93ea0
to
b9b06e8
Compare
msbrogli
changed the title
Feat/sync v2 improvements 3
feat(sync-v2): Add both BlockchainStreamingClient and TransactionStreamingClient to manage streamings from the client side
Nov 3, 2023
msbrogli
commented
Nov 3, 2023
msbrogli
commented
Nov 3, 2023
msbrogli
force-pushed
the
feat/sync-v2-improvements-3
branch
from
November 3, 2023 08:30
a340ba6
to
de60b5c
Compare
jansegre
requested changes
Nov 3, 2023
msbrogli
force-pushed
the
feat/sync-v2-improvements-2
branch
from
November 3, 2023 16:24
708b5a8
to
38158b6
Compare
msbrogli
force-pushed
the
feat/sync-v2-improvements-3
branch
from
November 3, 2023 16:25
de60b5c
to
e37b28a
Compare
msbrogli
force-pushed
the
feat/sync-v2-improvements-2
branch
from
November 3, 2023 17:51
38158b6
to
92bde24
Compare
msbrogli
force-pushed
the
feat/sync-v2-improvements-3
branch
from
November 3, 2023 17:52
e37b28a
to
952a22d
Compare
msbrogli
force-pushed
the
feat/sync-v2-improvements-2
branch
from
November 3, 2023 18:07
92bde24
to
4b04c9c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #848 +/- ##
==========================================
+ Coverage 85.01% 85.06% +0.05%
==========================================
Files 271 275 +4
Lines 22389 22502 +113
Branches 3417 3434 +17
==========================================
+ Hits 19034 19142 +108
+ Misses 2678 2674 -4
- Partials 677 686 +9
☔ View full report in Codecov by Sentry. |
msbrogli
force-pushed
the
feat/sync-v2-improvements-3
branch
from
November 3, 2023 18:25
952a22d
to
6d9b085
Compare
jansegre
reviewed
Nov 3, 2023
jansegre
previously approved these changes
Nov 3, 2023
jansegre
previously approved these changes
Nov 3, 2023
glevco
previously approved these changes
Nov 3, 2023
glevco
reviewed
Nov 3, 2023
jansegre
approved these changes
Nov 3, 2023
glevco
approved these changes
Nov 3, 2023
…amingClient to manage streamings from the client side
msbrogli
force-pushed
the
feat/sync-v2-improvements-3
branch
from
November 3, 2023 21:06
6dd0b59
to
eab8986
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Even though streaming servers were implemented on separated classes, the clients were intertwined within the sync agent.
Acceptance Criteria
BlockchainStreamingClient
to handle blockchain streamings.TransactionStreamingClient
to handle transaction streamings.until_first_block
tolast_block_hash
in GET-TRANSACTION-BFS message.first_block_hash
parameter to GET-TRANSACTION-BFS message.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged