-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(scripts): implement ScriptContext #851
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #851 +/- ##
==========================================
- Coverage 85.34% 85.25% -0.10%
==========================================
Files 281 282 +1
Lines 22392 22413 +21
Branches 3391 3402 +11
==========================================
- Hits 19111 19108 -3
- Misses 2599 2615 +16
- Partials 682 690 +8 ☔ View full report in Codecov by Sentry. |
e5a19b7
to
7c774b1
Compare
4ade1b1
to
309cd74
Compare
b8ac57b
to
431d711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but it's not a feature, it's a refactor, right?
f35564b
to
d3c075f
Compare
Motivation
Create the
ScriptContext
scaffolding that may be used by future opcodes.Acceptance Criteria
ScriptContext
class.execute_op_code()
, that takes aScriptContext
as an argument.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged