fix(verification): avoid validation downgrade by not running it twice #853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In new sync-v2 sync flow, a node can receive a transaction that it already has, but the node might run
validate_basic
before processing the transaction. Before this PR runningvalidate_basic
on an existing and fully verified transaction would run the validation and downgrade the validation state from FULL to BASIC.Acceptance Criteria
validate_basic
to skip the validation if the given transaction has already been validated at the same or higher validation level.Adjust bothRemoved from this PR because it affects other tests which require changes tovalidate_full
to skip the validation if the given transaction has already been validated at the same or higher validation level.HathorManager.on_new_tx
for a proper fix and this isn't needed for anything in sync-v2Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged