feat(sync-v2): Fix issue when a reorg occurs during a streaming of transactions #855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
An unhandled exception is raised by
current_block.get_next_block_best_chain()
when a reorg occurs during a streaming of transactions. This unhandled exception causes thesend_next()
to stop being called because it is not scheduled to run anymore, so the other peer stays hanging waiting for more transactions.Acceptance Criteria
get_next_block_best_chain()
. If not, stop the streaming.safe_send_next()
that will either schedule the next call or stop the streaming.StreamEnd.INTERNAL_ERROR
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged