Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync-v2): Stop streaming of transactions if an unexpected vertex is received #856

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Nov 9, 2023

Motivation

The first_block issue caused us to not stop the streaming of transactions when an unexpected vertex is received. But it not necessary to do it anymore because the streamer server is handling this case.

Acceptance Criteria

  1. Stop the streaming of transactions if an unexpected vertex is received.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner November 9, 2023 15:59
@msbrogli msbrogli requested a review from glevco November 9, 2023 15:59
@msbrogli msbrogli self-assigned this Nov 9, 2023
@msbrogli msbrogli added the enhancement New feature or request label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df21071) 85.43% compared to head (b0c394a) 85.40%.
Report is 3 commits behind head on master.

❗ Current head b0c394a differs from pull request most recent head 85683d6. Consider uploading reports for the commit 85683d6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   85.43%   85.40%   -0.03%     
==========================================
  Files         282      282              
  Lines       22253    22243      -10     
  Branches     3363     3361       -2     
==========================================
- Hits        19011    18996      -15     
- Misses       2576     2579       +3     
- Partials      666      668       +2     
Files Coverage Δ
hathor/p2p/sync_v2/transaction_streaming_client.py 90.19% <100.00%> (+0.09%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msbrogli msbrogli force-pushed the feat/sync-v2-streaming-client-unexpected-vertex branch from b0c394a to 85683d6 Compare November 9, 2023 17:08
@jansegre jansegre mentioned this pull request Nov 9, 2023
2 tasks
@msbrogli msbrogli force-pushed the feat/sync-v2-streaming-client-unexpected-vertex branch from 85683d6 to 382cc38 Compare November 9, 2023 23:03
@msbrogli msbrogli merged commit 382cc38 into master Nov 9, 2023
1 check passed
@msbrogli msbrogli deleted the feat/sync-v2-streaming-client-unexpected-vertex branch November 9, 2023 23:03
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants