feat(sync-v2): Watchdog to detect stale syncing #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
feat/sync-v2-watchdog
branch
2 times, most recently
from
02bd961 to
5e24bd2
Compare
jansegre
previously approved these changes
Nov 9, 2023
glevco
previously approved these changes
Nov 9, 2023
msbrogli
force-pushed
the
feat/sync-v2-watchdog
branch
from
5e24bd2 to
4882dd4
Compare
msbrogli
force-pushed
the
feat/sync-v2-watchdog
branch
from
4882dd4 to
45281a2
Compare
glevco
approved these changes
Nov 9, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sync-v2 might get stale if an unhandled exception occurs. Even though we want to learn about the issue to get it fixed, we also want the full node to recover from issues. So, this PR introduces a watchdog that closes the connection if the sync gets stale. The full node will automatically reconnect and try to sync again.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged