refactor(sync): remove legacy sync-v1.0 #864
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's been legacy for a while and we haven't even deployed any nodes with 1.0 support for a while.
Acceptance Criteria
SyncVersion.V1_1
(with value'v1.1'
) is used and neverSyncVersion.V1
(with value'v1'
) which could previously be used depending on a cli argument--x-enable-legacy-sync-v1_0
argument is removed, nothing else changes for the CLIChecklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged