Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync-v2): do not consider existing vertex as unexpected #866

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

jansegre
Copy link
Member

Motivation

When syncing transactions, there was a valid case where a node would incorrectly raise UnexpectedVertex if a transaction was previously present in the database, which could happen from a different sync agent running.

Acceptance Criteria

  • When considering the missing dependencies, remember the ones that already exist in the database and don't consider those unexpected.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Nov 10, 2023
@jansegre jansegre requested a review from msbrogli as a code owner November 10, 2023 15:15
@jansegre jansegre requested a review from glevco November 10, 2023 15:16
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e85ad70) 85.45% compared to head (a4238fa) 85.40%.

❗ Current head a4238fa differs from pull request most recent head 9fa42cd. Consider uploading reports for the commit 9fa42cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
- Coverage   85.45%   85.40%   -0.05%     
==========================================
  Files         281      281              
  Lines       22269    22236      -33     
  Branches     3374     3365       -9     
==========================================
- Hits        19029    18990      -39     
- Misses       2573     2580       +7     
+ Partials      667      666       -1     
Files Coverage Δ
hathor/p2p/sync_v2/transaction_streaming_client.py 85.04% <60.00%> (-4.09%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the fix/sync-v2-not-unexpected-vertex branch from a4238fa to 9fa42cd Compare November 10, 2023 16:16
@jansegre jansegre merged commit 0b32a31 into master Nov 10, 2023
7 of 8 checks passed
@jansegre jansegre deleted the fix/sync-v2-not-unexpected-vertex branch November 10, 2023 16:17
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants