feat(sync-v2): Stop running callLater when a block is voided in handle_get_peer_block_hashes()

[msbrogli]

Motivation

The handle_get_peer_block_hashes() method used to schedule a later call if one of the requested blocks was voided. This behavior was implemented due to issues in a previous implementation of the n-ary search. The current n-ary search implementation properly handles when a reorg occur during the search.

Acceptance Criteria

1. Stop scheduling a later call if a block is voided in handle_get_peer_block_hashes().
2. If a voided block is found, skip it and all following blocks in the response of the handle_get_peer_block_hashes(). It's safe to do it because the n-ary search algorithm can handle empty responses.
3. It's safe to skip the first voided block and all following blocks because this method assumes the list of heights will be increasingly sorted so all following blocks must be voided too.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (090bd71) 85.42% compared to head (1a0f0b3) 85.36%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
- Coverage   85.42%   85.36%   -0.07%     
==========================================
  Files         281      281              
  Lines       22353    22354       +1     
  Branches     3388     3388              
==========================================
- Hits        19096    19082      -14     
- Misses       2582     2591       +9     
- Partials      675      681       +6     

Files	Coverage Δ
hathor/p2p/sync_v2/agent.py	79.96% <80.00%> (-0.59%)	⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.