Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reliable-integration): change ordering to send voided txs first #876

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Nov 16, 2023

Motivation

Change the ordering of VERTEX_METADATA_CHANGED events. Before it was ordered by descending timestamp, which is a reverse topological ordering. We now sort by voided txs first, and untie by descending timestamp. This aids Reliable Integration client implementation.

Acceptance Criteria

  • Change ordering of events in the consensus to emit voided txs first, and then ordered by descending timestamp.
  • Add new UNVOIDED_TRANSACTION event simulator scenario and respective test.
  • Add include_metadata parameter in BaseTransaction.clone().

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the enhancement New feature or request label Nov 16, 2023
@glevco glevco self-assigned this Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a86be0) 85.30% compared to head (df903c3) 85.21%.
Report is 1 commits behind head on master.

❗ Current head df903c3 differs from pull request most recent head 59bdf45. Consider uploading reports for the commit 59bdf45 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
- Coverage   85.30%   85.21%   -0.09%     
==========================================
  Files         281      281              
  Lines       22364    22372       +8     
  Branches     3388     3387       -1     
==========================================
- Hits        19077    19065      -12     
- Misses       2603     2619      +16     
- Partials      684      688       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/reliable-integration/event-ordering branch 2 times, most recently from cafb96e to 21bfe91 Compare November 20, 2023 18:24
@glevco glevco marked this pull request as ready for review November 20, 2023 18:36
@glevco glevco force-pushed the feat/reliable-integration/event-ordering branch 2 times, most recently from 7cb5b15 to df903c3 Compare November 23, 2023 20:42
@glevco glevco force-pushed the feat/reliable-integration/event-ordering branch from df903c3 to 59bdf45 Compare November 24, 2023 15:22
@msbrogli msbrogli merged commit 59bdf45 into master Nov 24, 2023
1 check passed
@msbrogli msbrogli deleted the feat/reliable-integration/event-ordering branch November 24, 2023 15:26
@jansegre jansegre mentioned this pull request Nov 24, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants