feat(reliable-integration): change ordering to send voided txs first #876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change the ordering of
VERTEX_METADATA_CHANGED
events. Before it was ordered by descending timestamp, which is a reverse topological ordering. We now sort by voided txs first, and untie by descending timestamp. This aids Reliable Integration client implementation.Acceptance Criteria
UNVOIDED_TRANSACTION
event simulator scenario and respective test.include_metadata
parameter inBaseTransaction.clone()
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged