-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sync-v2): stop _process_transaction on error #877
Conversation
aff25ed
to
39e5169
Compare
39e5169
to
46f0041
Compare
46f0041
to
f65fdb4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #877 +/- ##
==========================================
- Coverage 85.30% 85.28% -0.02%
==========================================
Files 281 281
Lines 22364 22385 +21
Branches 3388 3392 +4
==========================================
+ Hits 19077 19091 +14
- Misses 2603 2609 +6
- Partials 684 685 +1 ☔ View full report in Codecov by Sentry. |
8a6abb5
to
7b6eb34
Compare
f65fdb4
to
ffd1cd1
Compare
Motivation
During the last QA when a node was syncing from scratch, we caught a case where more than one unexpected transaction was sent on a streamer, the first one correctly failed the streamer client, but the second one lead to an error because the deferred had already been called.
Acceptance Criteria
TransactionStreamingClient.fails
will not callself._deferred.errback
if the deferred has already been called.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged