Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature-activation): configure new NOP features on testnet #879

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Nov 22, 2023

Motivation

Configure the new NOP features in testnet to restart the Phased Testing.

The start height is 3.386.880, which is 38.000 blocks from the current best height in testnet. This is equivalent to 13 days, meaning the Phase Testing should start around Dec 6th. We need to deploy this code before that.

Acceptance Criteria

  • Configure new NOP features in testnet.yml and testnet.py.
  • Update logging from old to new NOP features.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29a622f) 85.29% compared to head (a96dc15) 85.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
+ Coverage   85.29%   85.36%   +0.06%     
==========================================
  Files         281      281              
  Lines       22364    22367       +3     
  Branches     3388     3388              
==========================================
+ Hits        19075    19093      +18     
+ Misses       2610     2595      -15     
  Partials      679      679              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review November 23, 2023 15:35
@glevco glevco merged commit aa5109f into master Nov 23, 2023
9 checks passed
@glevco glevco deleted the feat/feature-activation/config-nop-features branch November 23, 2023 18:19
@jansegre jansegre mentioned this pull request Nov 24, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants