fix: add health endpoint to openapi #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
previously approved these changes
Dec 8, 2023
luislhl
force-pushed
the
fix/add-health-endpoint-to-openapi
branch
from
491005a to
20752b6
Compare
jansegre
approved these changes
Dec 8, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #891 +/- ##
==========================================
+ Coverage 85.32% 85.35% +0.03%
==========================================
Files 283 283
Lines 22416 22416
Branches 3397 3397
==========================================
+ Hits 19126 19134 +8
+ Misses 2604 2600 -4
+ Partials 686 682 -4 ☔ View full report in Codecov by Sentry. |
glevco
approved these changes
Dec 8, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need the
/healthendpoint to be included in the OpenAPI definitions that generate the Nginx configAcceptance Criteria
/healthendpoint when generatedChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged