-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feature-activation): add feature settings validation #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
requested changes
Dec 15, 2023
glevco
force-pushed
the
feat/feature-activation/settings-validation
branch
2 times, most recently
from
January 8, 2024 21:30
48770c6
to
5fa6220
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #894 +/- ##
==========================================
+ Coverage 85.10% 85.13% +0.02%
==========================================
Files 293 294 +1
Lines 22719 22781 +62
Branches 3418 3426 +8
==========================================
+ Hits 19335 19394 +59
- Misses 2705 2706 +1
- Partials 679 681 +2 ☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Jan 18, 2024
msbrogli
previously approved these changes
Mar 4, 2024
glevco
force-pushed
the
feat/feature-activation/settings-validation
branch
from
March 4, 2024 21:11
5fa6220
to
b9fb592
Compare
msbrogli
previously approved these changes
Mar 5, 2024
jansegre
approved these changes
Mar 5, 2024
jansegre
previously approved these changes
Mar 5, 2024
glevco
force-pushed
the
feat/feature-activation/settings-validation
branch
from
March 5, 2024 15:52
3c94c98
to
2446dd2
Compare
msbrogli
approved these changes
Mar 5, 2024
jansegre
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements a validation that compares the Feature Activation settings from the configuration file, against the previous value that is stored in the database. This runs during full node initialization and is just to prevent human errors when editing those files, since one cannot remove or change existing features from there.
Acceptance Criteria
FeatureActivationStorage
that validates configured feature activation settings against the previous value from the database.reset-feature-settings
CLI tool for erasing saved feature settings.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged