feat(sync-v2): Improve logging when unexpected TRANSACTIONS-END or BLOCKS-END are received #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
feat/sync-v2-unexpected-logging
branch
from
ae3bd94 to
128b3d9
Compare
jansegre
reviewed
Feb 8, 2024
…OCKS-END are received
msbrogli
force-pushed
the
feat/sync-v2-unexpected-logging
branch
from
128b3d9 to
6e4bfff
Compare
jansegre
approved these changes
Feb 8, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It seems we are getting some unexpected
TRANSACTIONS-ENDandBLOCKS-ENDmessages due to a race condition caused by concurrent syncing. This logging improvement will help us to understand what's causing the race condition so it can be properly handled. This is not a major issue since the sync-v2 protocol easy recovers from this situation and keeps syncing.Acceptance Criteria
response_codeto theunexpected TRANSACTIONS-ENDlog message.response_codeto theunexpected BLOCKS-ENDlog message.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged