feat(cli): Use SIGUSR2 to run sysctl commands #949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes the CPU is so high that sysctl become irresponsive. So this PR adds another method to send command to sysctl.
Acceptance Criteria
run_node
.@signal_handler_safe
to mark setters as safe to be executed during a signal handling.require_signal_handler_safe: bool = False
to theSysctlRunner.run()
method._get_getter()
and_set_setter()
toget_getter()
andset_setter()
onSysctl
.set()
tounsafe_set()
onSysctl
. It also updates the docstring to explain that it is unsafe to call this method directly.max_enabled_sync
,enabled_sync_versions
andkill_connection
as signal handler safe onConnectionsManagerSysctl
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged