-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sysctl): Add core module with profiler commands to sysctl #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
previously approved these changes
Feb 9, 2024
jansegre
previously approved these changes
Feb 9, 2024
msbrogli
dismissed stale reviews from jansegre and pedroferreira1
via
February 9, 2024 22:52
d4e4c8e
msbrogli
force-pushed
the
feat/sysctl-profiler
branch
from
February 9, 2024 22:52
53d50e6
to
d4e4c8e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 85.34% 85.35% +0.01%
==========================================
Files 291 292 +1
Lines 22540 22568 +28
Branches 3393 3395 +2
==========================================
+ Hits 19236 19263 +27
- Misses 2630 2631 +1
Partials 674 674 ☔ View full report in Codecov by Sentry. |
pedroferreira1
approved these changes
Feb 12, 2024
jansegre
approved these changes
Feb 14, 2024
msbrogli
force-pushed
the
feat/sysctl-profiler
branch
from
February 14, 2024 22:05
d4e4c8e
to
1f68ec7
Compare
jansegre
added a commit
that referenced
this pull request
Feb 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently must use an HTTP API to start and stop a global profiler. Such an API might not be accessible due to networking issues so having the ability to do it through sysctl becomes relevant.
Acceptance Criteria
core.profiler.status
,core.profiler.start
, andcore.profiler.stop
in sysctl.HathorManagerSysctl
which handles all these commands.HathorManager.is_profiler_running
to keep track whether the profiler is running or not.HathorManager.profiler_last_start_time
to be able to calculate how long the profiler has been running.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged