fix(cli): Fix issue when running sysctl through USR2 in macOS #956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
macOS has a different behavior when handling named pipes created by
mkfifo
.In macOS, if a fifo is opened for reading, the
open()
call will block if there are no writers—that is, if somebody else does not have the fifo open for writing.In Linux, the
open()
call is not blocking so the previous code worked fine and logged the fifo path as expected.Acceptance Criteria
open()
call fromtemp_fifo()
.open()
after logging the fifo path.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged