Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary asserts #968

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Mar 13, 2024

Depends on #967

Motivation

Since the BaseTransaction.hash property has been converted from Optional[bytes] to bytes, multiple assertions can be removed.

Acceptance Criteria

  • Remove instances of assert tx.hash is not None and equivalent.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Mar 13, 2024
@glevco glevco force-pushed the refactor/hash-property branch from 43eb06d to 5916646 Compare March 13, 2024 16:02
@glevco glevco force-pushed the chore/remove-unnecessary-asserts branch from cb06200 to e0caeb2 Compare March 13, 2024 16:02
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.08%. Comparing base (adc0191) to head (20f5c6d).
Report is 2 commits behind head on master.

❗ Current head 20f5c6d differs from pull request most recent head 04a8ed9. Consider uploading reports for the commit 04a8ed9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
- Coverage   85.10%   85.08%   -0.03%     
==========================================
  Files         296      295       -1     
  Lines       22909    22755     -154     
  Branches     3449     3443       -6     
==========================================
- Hits        19497    19360     -137     
+ Misses       2732     2710      -22     
- Partials      680      685       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/hash-property branch from 5916646 to 6c494e6 Compare March 19, 2024 16:28
Base automatically changed from refactor/hash-property to master March 19, 2024 18:49
@glevco glevco force-pushed the chore/remove-unnecessary-asserts branch from e0caeb2 to 20f5c6d Compare March 25, 2024 21:39
@glevco glevco marked this pull request as ready for review March 27, 2024 19:11
@glevco glevco force-pushed the chore/remove-unnecessary-asserts branch from 20f5c6d to 04a8ed9 Compare April 17, 2024 00:17
@jansegre jansegre merged commit 8dc9833 into master Apr 18, 2024
11 checks passed
@jansegre jansegre deleted the chore/remove-unnecessary-asserts branch April 18, 2024 16:15
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants