fix(indexes): Fix wrong order in MemoryTxGroupIndex #977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
MemoryTxGroupIndex._get_sorted_from_key()
is returning transactions in the wrong order. The correct order is sorted by (timestamp, hash) but it is actually only sorting by hash.Acceptance Criteria
set[bytes]
toset[tuple[int, bytes]]
so we can simply sort before returning the results._get_sorted_from_key()
sorting the tuple but returning only the hashes.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged