Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix OpenAPI url of cpu profiler endpoint #979

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

jansegre
Copy link
Member

Motivation

When going through the docs with @BrunoCampana we noticed that this endpoint wasn't showing up on the docs.

Acceptance Criteria

  • The correct endpoint for the "top API" (cpu profiler) is /top and the OpenAPI should use that, /profiler is used by a different endpoint and using it causes one to overshadow the other.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested a review from BrunoCampana March 18, 2024 19:36
@jansegre jansegre self-assigned this Mar 18, 2024
@jansegre jansegre requested a review from msbrogli as a code owner March 18, 2024 19:36
@jansegre jansegre force-pushed the docs/fix-top-openapi-url branch from 19f70ad to 2ed45ec Compare March 18, 2024 19:37
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (a2ee438) to head (2ed45ec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   85.05%   85.14%   +0.08%     
==========================================
  Files         294      294              
  Lines       22782    22782              
  Branches     3428     3428              
==========================================
+ Hits        19378    19397      +19     
+ Misses       2718     2706      -12     
+ Partials      686      679       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the docs/fix-top-openapi-url branch from 2ed45ec to 7d061a1 Compare March 20, 2024 20:52
@jansegre jansegre merged commit 7bcc669 into master Mar 20, 2024
11 checks passed
@jansegre jansegre deleted the docs/fix-top-openapi-url branch March 20, 2024 20:54
@jansegre jansegre mentioned this pull request Apr 5, 2024
2 tasks
@jansegre jansegre mentioned this pull request May 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants