feat(cli): add argument to make sync-v1 unavailable #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
force-pushed
the
feat/arg-to-make-sync-v1-unavailable
branch
2 times, most recently
from
de2ba65 to
9a20717
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 84.92% 84.93% +0.01%
==========================================
Files 298 298
Lines 22952 22962 +10
Branches 3466 3470 +4
==========================================
+ Hits 19492 19503 +11
+ Misses 2774 2772 -2
- Partials 686 687 +1 ☔ View full report in Codecov by Sentry. |
jansegre
force-pushed
the
feat/arg-to-make-sync-v1-unavailable
branch
from
9a20717 to
29eaa1a
Compare
glevco
reviewed
Apr 2, 2024
msbrogli
previously approved these changes
Apr 18, 2024
jansegre
force-pushed
the
feat/arg-to-make-sync-v1-unavailable
branch
from
29eaa1a to
78c5e79
Compare
msbrogli
previously approved these changes
May 2, 2024
jansegre
force-pushed
the
feat/arg-to-make-sync-v1-unavailable
branch
from
78c5e79 to
c641b44
Compare
glevco
previously approved these changes
May 2, 2024
jansegre
force-pushed
the
feat/arg-to-make-sync-v1-unavailable
branch
from
c641b44 to
57c9c39
Compare
Currently it is possibly to disable sync-v1 but not make it unavailable. Making it unavailble will be required in order to be able to disable the indexes that it needs. This commit does not bother on any of the effects that are possible when sync-v1 is unavailable, only on making it possible to do so via a command line argument.
jansegre
force-pushed
the
feat/arg-to-make-sync-v1-unavailable
branch
from
57c9c39 to
3170851
Compare
msbrogli
approved these changes
May 2, 2024
glevco
approved these changes
May 2, 2024
This was referenced May 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In preparation to phase-out sync-v1, we would benefit from having a method for starting the node without sync-v1 indexes. This PR does not go into the details of which index is used, it only makes it possible to start with a node where sync-v1 is "not available" as opposed to just "disabled"; "not available" means it cannot be enabled in runtime.
Acceptance Criteria
--x-remove-sync-v1CLI option to make sync-v1 unavailable from the startChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged