fix(events): add missing signal_bits to event schema #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 85.15% 85.07% -0.08%
==========================================
Files 296 296
Lines 22901 22902 +1
Branches 3447 3447
==========================================
- Hits 19501 19484 -17
- Misses 2721 2732 +11
- Partials 679 686 +7 ☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Apr 4, 2024
msbrogli
reviewed
Apr 5, 2024
msbrogli
approved these changes
Apr 5, 2024
glevco
force-pushed
the
fix/event-signal-bits
branch
from
84c2347 to
93e3661
Compare
msbrogli
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
signal_bitsfield was missing from Reliable Integration events. This is not a problem because no Reliable Integration client uses this field, but for completeness, this PR adds it.Acceptance Criteria
signal_bitstoTxData.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged