Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated resource method from address history API #994

Merged

Conversation

pedroferreira1
Copy link
Member

Motivation

We deprecated the address_history API without paginate=true parameter on March 2020 (a8ae6d8). This API has low performance for addresses with many transactions and that's why it was deprecated.

After many years, we are removing it to prevent someone from using it by mistake and consuming the full node's CPU.

Acceptance Criteria

  • Remove deprecated method resource from address_history API.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@pedroferreira1 pedroferreira1 requested a review from glevco April 4, 2024 04:37
@pedroferreira1 pedroferreira1 self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (e889e7a) to head (486b9de).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   85.08%   85.06%   -0.02%     
==========================================
  Files         296      296              
  Lines       22925    22901      -24     
  Branches     3452     3447       -5     
==========================================
- Hits        19505    19480      -25     
  Misses       2734     2734              
- Partials      686      687       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedroferreira1 pedroferreira1 merged commit 929d88b into master Apr 4, 2024
12 checks passed
@pedroferreira1 pedroferreira1 deleted the refactor/remove-deprecated-resource-address-history branch April 4, 2024 16:09
@jansegre jansegre mentioned this pull request Apr 5, 2024
2 tasks
@jansegre jansegre mentioned this pull request May 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants