-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revamp home ui #334
feat: revamp home ui #334
Conversation
Release v0.19.0
Release v0.19.1
Release v0.20.0
Release: v0.20.1
Release v0.20.3
Release v0.20.4
To quickly test the new UI without modifying the feature flag response, simply update the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to our project! Here are some questions and suggestions on an initial partial review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to any file in specific: When running the application in localhost using the new UI, I'm receiving the following warning on browser console:
index.js:26 Warning: validateDOMNesting(...): <li> cannot appear as a descendant of <li>.
at li
at ConditionalNavigation (http://localhost:3000/static/js/main.chunk.js:4765:5)
This may be related to some specific usage on the Navigation.js
file, but I'm unsure of its source as of now.
It's because of the dropdown, can we fix it in the next PR? it would take some time to refactor this. |
Hello @julia-eileen ,
If you want, you can also squash all commits into one, so that the signing is made easier. |
299bb40
to
50ceb94
Compare
50ceb94
to
298a030
Compare
Hi @tuliomir , Thank you for pointing that out and for providing the helpful guide! I’ve followed the instructions and signed all of my commits. Please let me know if everything looks good now or if there’s anything else I need to adjust. Thanks again for your support and patience! 🦊 |
Acceptance Criteria
Security Checklist
2024-10-16.12-30-01.mp4
2024-10-16.13-39-59.mp4